net/url_request/url_request_job_factory_impl_unittest.cc - Issue 2265873002: Adjust callers and networking delegates in net/ to modified APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_factory_impl_unittest.cc

Issue 2265873002: Adjust callers and networking delegates in net/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/test/spawned_test_server/spawner_communicator.cc ('K') | « net/url_request/url_request_http_job_unittest.cc ('k') | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_job_factory_impl_unittest.cc

diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc

index d0dd374ded77f8bb6386e6b7cfe5e5ce104ddcbe..871bd4711c7bac66d39d184dec598471c996ad47 100644

--- a/net/url_request/url_request_job_factory_impl_unittest.cc

+++ b/net/url_request/url_request_job_factory_impl_unittest.cc

@@ -69,8 +69,7 @@ TEST(URLRequestJobFactoryTest, NoProtocolHandler) {

request->Start();

base::RunLoop().Run();

- EXPECT_EQ(URLRequestStatus::FAILED, request->status().status());

- EXPECT_THAT(request->status().error(), IsError(ERR_UNKNOWN_URL_SCHEME));

+ EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, delegate.request_status());

}

TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {

@@ -85,8 +84,7 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {

request->Start();

base::RunLoop().Run();

- EXPECT_EQ(URLRequestStatus::SUCCESS, request->status().status());

- EXPECT_THAT(request->status().error(), IsOk());

+ EXPECT_EQ(OK, delegate.request_status());

}

TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {