Streams: Remove isTerminating() calls

Streams: Remove isTerminating() calls

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877
Committed: https://crrev.com/53752ac68bbd8b93650a9475c9b5b5f2e13a8e9a
Cr-Commit-Position: refs/heads/master@{#413420}

[nhiroki, 2016-08-22 03:38:54]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 03:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-08-22 04:30:15]

Description was changed from

==========
Streams: Remove isTerminating() calls

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
WorkerThread graceful shutdown mechanism (https://crbug.com/487050)

BUG=614272, 638877
==========

to

==========
Streams: Remove isTerminating() calls

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877
==========

[nhiroki, 2016-08-22 04:32:20]

nhiroki@chromium.org changed reviewers:
+ yhirano@chromium.org

[nhiroki, 2016-08-22 04:32:21]

PTAL, thanks!

[haraken, 2016-08-22 04:35:38]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-08-22 04:35:39]

LGTM

https://codereview.chromium.org/2265863002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/2265863002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:113: if
(bodyValue.IsEmpty())

I recently changed toV8 so that it never returns an empty handle. You don't need
to change it in this CL though. FYI.

[commit-bot: I haz the power, 2016-08-22 05:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 05:03:57]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-08-22 06:22:13]

lgtm, thanks.

https://codereview.chromium.org/2265863002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/2265863002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:113: if
(bodyValue.IsEmpty())
On 2016/08/22 04:35:39, haraken wrote:
> 
> I recently changed toV8 so that it never returns an empty handle. You don't
need
> to change it in this CL though. FYI.

+1

[nhiroki, 2016-08-22 06:57:46]

Thank you for reviewing.

https://codereview.chromium.org/2265863002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/2265863002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:113: if
(bodyValue.IsEmpty())
On 2016/08/22 06:22:13, yhirano wrote:
> On 2016/08/22 04:35:39, haraken wrote:
> > 
> > I recently changed toV8 so that it never returns an empty handle. You don't
> need
> > to change it in this CL though. FYI.
> 
> +1

Removed the empty checks in this CL.

[nhiroki, 2016-08-22 06:57:52]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-08-22 06:57:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2265863002/#ps40001
(title: "remove empty checks")

[commit-bot: I haz the power, 2016-08-22 06:58:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 08:28:00]

Description was changed from

==========
Streams: Remove isTerminating() calls

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877
==========

to

==========
Streams: Remove isTerminating() calls

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877
==========

[commit-bot: I haz the power, 2016-08-22 08:28:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 08:29:40]

Description was changed from

==========
Streams: Remove isTerminating() calls

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877
==========

to

==========
Streams: Remove isTerminating() calls

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877

Committed: https://crrev.com/53752ac68bbd8b93650a9475c9b5b5f2e13a8e9a
Cr-Commit-Position: refs/heads/master@{#413420}
==========

[commit-bot: I haz the power, 2016-08-22 08:29:41]

Patchset 3 (id:??) landed as
https://crrev.com/53752ac68bbd8b93650a9475c9b5b5f2e13a8e9a
Cr-Commit-Position: refs/heads/master@{#413420}

[nhiroki, 2016-08-24 11:16:22]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2277703002/ by nhiroki@chromium.org.

The reason for reverting is: This causes crashes (see
https://bugs.chromium.org/p/chromium/issues/detail?id=640521).