third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html - Issue 2265823002: DevTools: fix instances where asParsedURL is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html

Issue 2265823002: DevTools: fix instances where asParsedURL is null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix instances with parsedURL Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html b/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html

index de009599f69ed2bb789537dacba8b9a182982ac3..d612d373401ab441160bf065ae04f0938cf5d7c6 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html

@@ -29,8 +29,10 @@ function test()

continue;

}

var parsedURL = href.asParsedURL();

- if (!parsedURL)

+ if (!parsedURL) {

testController.notifyDone("FAIL: no URL match for <" + href + ">");

+ continue;

+ }

var split = parsedURL.path.split("/");

for (var i = split.length - 1, j = 0; j < 3 && i >= 0; --i, ++j)

segments.push(split[i]);

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »