third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2265823002: DevTools: fix instances where asParsedURL is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2265823002: DevTools: fix instances where asParsedURL is null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix instances with parsedURL Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('K') | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 1ebc58a52a3590545eef4cae39a81abb67f59222..7cb5763e9b0a4e86a84624e395a96b9c34193930 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -987,9 +987,10 @@ WebInspector.NetworkLogView.prototype = {

_exportAll: function()

{

var url = WebInspector.targetManager.mainTarget().inspectedURL();

- var filename = url.asParsedURL().host + ".har";

+ var parsedURL = url.asParsedURL();

+ var filename = parsedURL ? parsedURL.host : WebInspector.UIString("filename");

dgozman 2016/08/22 17:05:43 Let's use |url| as a fallback.

luoe 2016/08/22 17:40:40 Done.

var stream = new WebInspector.FileOutputStream();

- stream.open(filename, openCallback.bind(this));

+ stream.open(filename + ".har", openCallback.bind(this));

/**

* @param {boolean} accepted