Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2265813002: Add a hack to set shouldPaint to true for force-composited iframes. (Closed)

Created:
4 years, 4 months ago by wkorman
Modified:
4 years, 4 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a hack to set shouldPaint to true for force-composited iframes. This works around a FCB chicken-egg problem in which we are unable to properly start painting floating iframes once they stop being composited. Reland of original change http://crrev.com/2009353003 now that we've reviewed performance without the patch. BUG=610906, 619710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=chrishtr Committed: https://crrev.com/77f8e3dd7c2c7feb739b9918a2ecca94e7ad3e36 Cr-Commit-Position: refs/heads/master@{#413649}

Patch Set 1 #

Patch Set 2 : Add new test to SPv2 expectations. #

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265813002/1
4 years, 4 months ago (2016-08-21 21:56:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/106)
4 years, 4 months ago (2016-08-21 22:32:17 UTC) #6
wkorman
4 years, 4 months ago (2016-08-22 19:39:22 UTC) #8
chrishtr
lgtm
4 years, 4 months ago (2016-08-22 20:03:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265813002/20001
4 years, 4 months ago (2016-08-22 22:34:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/127368)
4 years, 4 months ago (2016-08-23 01:03:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265813002/20001
4 years, 4 months ago (2016-08-23 02:07:07 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 02:53:22 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 02:55:20 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77f8e3dd7c2c7feb739b9918a2ecca94e7ad3e36
Cr-Commit-Position: refs/heads/master@{#413649}

Powered by Google App Engine
This is Rietveld 408576698