Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2265793002: Code clean-up (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/analyzer/lib/src/util/fast_uri.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/constant_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_scanner_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-21 15:26:55 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-21 18:23:42 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-21 22:48:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2797cf53675acfb9223111cce4c63924cd5a04c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698