Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2265713002: [tools/perf] Initialize network_controller_backend in dual_browser_story_shared_state (Closed)

Created:
4 years, 4 months ago by nednguyen(REVIEW IN OTHER ACC)
Modified:
4 years, 4 months ago
Reviewers:
perejzu, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Initialize network_controller_backend in dual_browser_story_shared_state BUG=catapult:#2584 TBR=perejzu@chromium.org Committed: https://crrev.com/3ab8e7edb730b85448fa8a58e19a02b6836000a1 Cr-Commit-Position: refs/heads/master@{#413335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/perf/page_sets/dual_browser_story.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
nednguyen
lgtm
4 years, 4 months ago (2016-08-20 02:37:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265713002/1
4 years, 4 months ago (2016-08-20 02:38:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/277675)
4 years, 4 months ago (2016-08-20 03:58:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265713002/1
4 years, 4 months ago (2016-08-20 09:41:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 10:59:07 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 11:00:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ab8e7edb730b85448fa8a58e19a02b6836000a1
Cr-Commit-Position: refs/heads/master@{#413335}

Powered by Google App Engine
This is Rietveld 408576698