Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2265703002: [Sync] Fix bug in NonUIDataTypeController::Stop(). (Closed)

Created:
4 years, 4 months ago by maxbogue
Modified:
4 years, 4 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix bug in NonUIDataTypeController::Stop(). The shared change processor should always be cleared. BUG=639449 Committed: https://crrev.com/5567c4aeb3c878a8b92c68977e1c0507b187a592 Cr-Commit-Position: refs/heads/master@{#413372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -50 lines) Patch
M chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc View 1 chunk +1 line, -7 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller.h View 1 chunk +2 lines, -6 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller.cc View 4 chunks +9 lines, -37 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
maxbogue
Pavel, PTAL. I tried to clean up the method as much as I could. Now ...
4 years, 4 months ago (2016-08-20 22:56:45 UTC) #6
pavely
lgtm
4 years, 4 months ago (2016-08-21 05:48:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265703002/1
4 years, 4 months ago (2016-08-21 06:10:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-21 07:12:00 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 07:13:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5567c4aeb3c878a8b92c68977e1c0507b187a592
Cr-Commit-Position: refs/heads/master@{#413372}

Powered by Google App Engine
This is Rietveld 408576698