recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py - Issue 2265673002: Add LogDog / annotation protobuf support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py

Issue 2265673002: Add LogDog / annotation protobuf support. (Closed) Base URL: https://github.com/luci/recipes-py@step-formal-struct

Patch Set: Updated with comments, added test, proto 3.0.2. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« recipe_engine/stream_logdog.py ('K') | « recipe_engine/third_party/client-py/libs/logdog/streamname.py ('k') | recipe_engine/third_party/client-py/libs/logdog/tests/streamname_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py

diff --git a/recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py b/recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py

index c05d05f08f8804b751e32c6f13d73a18cdfd7bca..98cbbdacb971f7362546eb45df12b4afdefe2f44 100755

--- a/recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py

+++ b/recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py

@@ -84,6 +84,10 @@ class StreamClientTestCase(unittest.TestCase):

def interpret(self):

data = StringIO.StringIO(self.buffer.getvalue())

+ magic = data.read(len(stream.BUTLER_MAGIC))

+ if magic != stream.BUTLER_MAGIC:

+ raise ValueError('Invalid magic value ([%s] != [%s])' % (

+ magic, stream.BUTLER_MAGIC))

length, _ = varint.read_uvarint(data)

header = data.read(length)

return json.loads(header), data.read()