Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 2265653002: Allow html5 videos to be played inline. (Closed)

Created:
4 years, 4 months ago by michaeldo
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow html5 videos to be played inline. Enable inline video playback on iOS10 or greater. BUG=395206 Committed: https://crrev.com/dda197228ead6ded174cca549a83150c712bcfb2 Cr-Commit-Position: refs/heads/master@{#413457}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
michaeldo
4 years, 4 months ago (2016-08-19 20:52:30 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2265653002/diff/1/ios/web/web_state/ui/wk_web_view_configuration_provider.mm File ios/web/web_state/ui/wk_web_view_configuration_provider.mm (right): https://codereview.chromium.org/2265653002/diff/1/ios/web/web_state/ui/wk_web_view_configuration_provider.mm#newcode75 ios/web/web_state/ui/wk_web_view_configuration_provider.mm:75: [configuration_ setAllowsInlineMediaPlayback:YES]; If this does not break anything ...
4 years, 4 months ago (2016-08-19 21:32:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265653002/20001
4 years, 4 months ago (2016-08-22 15:56:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 16:47:10 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:50:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dda197228ead6ded174cca549a83150c712bcfb2
Cr-Commit-Position: refs/heads/master@{#413457}

Powered by Google App Engine
This is Rietveld 408576698