Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 2265643002: Rename circular_arcs_circular_arcs_fill to circular_arcs_fill (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename circular_arcs_circular_arcs_fill to circular_arcs_fill. Also fix issue with second paint's alpha getting overwritten. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265643002 Committed: https://skia.googlesource.com/skia/+/4c54788e9298dce2b963ce288baf0d1695323e1f

Patch Set 1 #

Patch Set 2 : Also fix issue with second paint's alpha #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M gm/circulararcs.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bsalomon
4 years, 4 months ago (2016-08-19 20:16:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265643002/1
4 years, 4 months ago (2016-08-19 20:16:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265643002/20001
4 years, 4 months ago (2016-08-19 20:21:12 UTC) #9
egdaniel
lgtm
4 years, 4 months ago (2016-08-19 20:26:25 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 20:41:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4c54788e9298dce2b963ce288baf0d1695323e1f

Powered by Google App Engine
This is Rietveld 408576698