Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2265623002: src/utils/SkBitSet: simplify (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : 2016-08-19 (Friday) 16:05:19 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -172 lines) Patch
M gyp/utils.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFMakeCIDGlyphWidthsArray.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkBitSet.h View 3 chunks +21 lines, -42 lines 0 comments Download
D src/utils/SkBitSet.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
M src/xps/SkXPSDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitSetTest.cpp View 1 chunk +22 lines, -56 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
hal.canary
ptal
4 years, 4 months ago (2016-08-19 20:34:58 UTC) #10
bungeman-skia
lgtm
4 years, 4 months ago (2016-08-19 20:54:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265623002/20001
4 years, 4 months ago (2016-08-19 23:21:07 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 23:23:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/e2348ccb477b97847cd147161a57fbbbfc8bba10

Powered by Google App Engine
This is Rietveld 408576698