Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2265593002: Add writeAsStringSync (issue 27109) (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : store bytes rather than strings #

Patch Set 3 : Use UTF8 for conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -25 lines) Patch
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 2 12 chunks +24 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +29 lines, -6 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +16 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-19 18:15:54 UTC) #2
Brian Wilkerson
PTAL
4 years, 4 months ago (2016-08-19 18:53:39 UTC) #3
Brian Wilkerson
PTAL
4 years, 4 months ago (2016-08-19 19:13:22 UTC) #4
scheglov
LGTM https://codereview.chromium.org/2265593002/diff/1/pkg/analyzer/lib/file_system/file_system.dart File pkg/analyzer/lib/file_system/file_system.dart (right): https://codereview.chromium.org/2265593002/diff/1/pkg/analyzer/lib/file_system/file_system.dart#newcode64 pkg/analyzer/lib/file_system/file_system.dart:64: * Synchronously write a the given [content] to ...
4 years, 4 months ago (2016-08-19 19:15:18 UTC) #5
Brian Wilkerson
https://codereview.chromium.org/2265593002/diff/1/pkg/analyzer/lib/file_system/file_system.dart File pkg/analyzer/lib/file_system/file_system.dart (right): https://codereview.chromium.org/2265593002/diff/1/pkg/analyzer/lib/file_system/file_system.dart#newcode64 pkg/analyzer/lib/file_system/file_system.dart:64: * Synchronously write a the given [content] to the ...
4 years, 4 months ago (2016-08-19 19:17:04 UTC) #6
Brian Wilkerson
4 years, 4 months ago (2016-08-19 19:17:17 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
17ffa1e9c0a95d877574276ea694a98f46bd06bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698