Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2265543002: GCM: Handle non-Strings in incoming message Bundle (Closed)

Created:
4 years, 4 months ago by johnme
Modified:
4 years, 4 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GCM: Handle non-Strings in incoming message Bundle Google Cloud Messaging recently started including a "google.sent_time" Long in the incoming message Bundle from Google Play Services. This patch filters out non-String values to prevent warnings about ClassCastExceptions. BUG=639313 Committed: https://crrev.com/6688926c9db1c186b24b729fe8c8588f747a1a4a Cr-Commit-Position: refs/heads/master@{#413435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Peter Beverloo
lgtm (note that you didn't send this out)
4 years, 4 months ago (2016-08-21 21:04:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265543002/1
4 years, 4 months ago (2016-08-22 12:41:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 13:15:37 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 13:17:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6688926c9db1c186b24b729fe8c8588f747a1a4a
Cr-Commit-Position: refs/heads/master@{#413435}

Powered by Google App Engine
This is Rietveld 408576698