runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart - Issue 2265513003: Converted Observatory object-common element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart

Issue 2265513003: Converted Observatory object-common element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/mocks/objects/retaining_path.dart ('k') | runtime/observatory/tests/observatory_ui/mocks/repositories/inbound_references.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart

diff --git a/runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart b/runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart

index 1d77a3589eb04176008a4e9a8a216d7ddd79c642..5fb6a8a8ef01e3127e3e00e42a70a6ac90df5875 100644

--- a/runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart

+++ b/runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart

@@ -4,10 +4,10 @@

part of mocks;

-class Sentinel implements M.Sentinel {

+class SentinelMock implements M.Sentinel {

final M.SentinelKind kind;

final String valueAsString;

- const Sentinel({this.kind: M.SentinelKind.collected,

+ const SentinelMock({this.kind: M.SentinelKind.collected,

this.valueAsString: 'sentinel-value'});

}