runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart - Issue 2265513003: Converted Observatory object-common element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart

Issue 2265513003: Converted Observatory object-common element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/mocks/objects/inbound_references.dart ('k') | runtime/observatory/tests/observatory_ui/mocks/objects/retaining_path.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart

diff --git a/runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart b/runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart

index d40059ababdea9988f7b60623d186f8956e3a815..bb8f6c270120b10b6e5fb61d2af8fe658d22d7a6 100644

--- a/runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart

+++ b/runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart

@@ -49,7 +49,8 @@ class InstanceMock implements M.Instance {

final M.InstanceRef referent;

const InstanceMock({this.id: 'instance-id', this.name: 'instance-name',

- this.kind: M.InstanceKind.vNull, this.clazz, this.size,

+ this.kind: M.InstanceKind.vNull,

+ this.clazz: const ClassRefMock(), this.size: 0,

this.valueAsString: 'null', this.valueAsStringIsTruncated,

this.length, this.typeClass, this.parameterizedClass,

this.pattern, this.closureFunction, this.offset,