Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2265513003: Converted Observatory object-common element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 2d563dd42408745bf3115d5f713360ac46262153..ddaa39623175a9bcabac0fd4853423ba23d555f2 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -93,7 +93,7 @@ class FakeVMRpcException extends RpcException {
}
/// A [ServiceObject] represents a persistent object within the vm.
-abstract class ServiceObject extends Observable implements M.ObjectRef {
+abstract class ServiceObject extends Observable {
static int LexicalSortName(ServiceObject o1, ServiceObject o2) {
return o1.name.compareTo(o2.name);
}
@@ -380,7 +380,7 @@ abstract class ServiceObject extends Observable implements M.ObjectRef {
}
}
-abstract class HeapObject extends ServiceObject {
+abstract class HeapObject extends ServiceObject implements M.Object {
@observable Class clazz;
@observable int size;
@observable int retainedSize;
@@ -1078,6 +1078,48 @@ class TagProfile {
}
}
+class InboundReferences implements M.InboundReferences {
+ final Iterable<InboundReference> elements;
+
+ InboundReferences(ServiceMap map)
+ : this.elements = map['references']
+ .map((rmap) => new InboundReference(rmap));
+}
+
+class InboundReference implements M.InboundReference {
+ final HeapObject source;
+ final Instance parentField;
+ final int parentListIndex;
+ final int parentWordOffset;
+
+ InboundReference(ServiceMap map)
+ : source = map['source'],
+ parentField = map['parentField'],
+ parentListIndex = map['parentListIndex'],
+ parentWordOffset = map['_parentWordOffset'];
+}
+
+class RetainingPath implements M.RetainingPath {
+ final Iterable<RetainingPathItem> elements;
+
+ RetainingPath(ServiceMap map)
+ : this.elements = map['elements']
+ .map((rmap) => new RetainingPathItem(rmap));
+}
+
+class RetainingPathItem implements M.RetainingPathItem {
+ final HeapObject source;
+ final Instance parentField;
+ final int parentListIndex;
+ final int parentWordOffset;
+
+ RetainingPathItem(ServiceMap map)
+ : source = map['value'],
+ parentField = map['parentField'],
+ parentListIndex = map['parentListIndex'],
+ parentWordOffset = map['_parentWordOffset'];
+}
+
class HeapSpace extends Observable implements M.HeapSpace {
@observable int used = 0;
@observable int capacity = 0;
@@ -2546,10 +2588,10 @@ class Instance extends HeapObject implements M.Instance {
@observable Iterable<BoundField> fields;
@observable var nativeFields;
- @observable Iterable<Guarded<ServiceObject>> elements; // If a List.
+ @observable Iterable<Guarded<HeapObject>> elements; // If a List.
@observable Iterable<MapAssociation> associations; // If a Map.
@observable Iterable<dynamic> typedElements; // If a TypedData.
- @observable ServiceObject referent; // If a MirrorReference.
+ @observable HeapObject referent; // If a MirrorReference.
@observable Instance key; // If a WeakProperty.
@observable Instance value; // If a WeakProperty.
@observable Breakpoint activationBreakpoint; // If a Closure.
@@ -2904,7 +2946,7 @@ class Sentinel extends ServiceObject implements M.Sentinel {
class Field extends HeapObject implements M.FieldRef {
// Library or Class.
- @observable ServiceObject dartOwner;
+ @observable HeapObject dartOwner;
@observable Library library;
@observable Instance declaredType;
@observable bool isStatic;
« no previous file with comments | « runtime/observatory/lib/src/repositories/retaining_path.dart ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698