Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2265503002: GN: _turbo -> -turbo to match Fuchsia (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
hcm, mtklein, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: _turbo -> -turbo to match Fuchsia We might as well match the folks who are using our GN files now. We've got plenty of strategies in our pocket for when we try to move Chrome onto our GN files (and who knows, there may be even a new better way by then): * Same sort of rename in Chrome's third_party * Aliased targets via //build/secondary in Chrome. * Indirection via build_overrides BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265503002 Committed: https://skia.googlesource.com/skia/+/0a8efd7355f3e258b1b4b1da6babfc8f1718ecd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/libjpeg-turbo/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/libjpeg_turbo/BUILD.gn View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mtklein_C
4 years, 4 months ago (2016-08-19 14:05:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265503002/1
4 years, 4 months ago (2016-08-19 14:05:18 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 4 months ago (2016-08-19 21:01:06 UTC) #8
jcgregorio
lgtm
4 years, 4 months ago (2016-08-19 21:06:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265503002/1
4 years, 4 months ago (2016-08-22 13:09:07 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 13:32:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0a8efd7355f3e258b1b4b1da6babfc8f1718ecd4

Powered by Google App Engine
This is Rietveld 408576698