Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2265483002:
chrome.gpuBenchmarking.printPagesToSkPictures (Closed)
|
Created:
4 years, 4 months ago by hal.canary Modified:
4 years, 4 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionchrome.gpuBenchmarking.printPagesToSkPictures
To use:
Launch Chrome with
--enable-gpu-benchmarking --no-sandbox
In the javascript console,
chrome.gpuBenchmarking.printPagesToSkPictures('/tmp/file.mskp')
Motivation: make debugging printing issues easier.
BUG=599185
Committed: https://crrev.com/2510d9da2799341fc2acd774088a9819bcd6c71e
Cr-Commit-Position: refs/heads/master@{#413775}
Patch Set 1 : 2016-08-19 (Friday) 10:28:58 EDT #Patch Set 2 : 2016-08-19 (Friday) 10:36:31 EDT #
Total comments: 4
Patch Set 3 : respond to Lei #
Messages
Total messages: 24 (14 generated)
Description was changed from
==========
GpuBenchmarking::PrintPagesToSkPictures
BUG=
==========
to
==========
chrome.gpuBenchmarking.printPagesToSkPictures
To use:
Launch Chrome with
--enable-gpu-benchmarking --no-sandbox
In the javascript console,
chrome.gpuBenchmarking.printPagesToSkPictures('/tmp/file.mskp')
Motivation: make debugging printing issues easier.
BUG=599185
==========
halcanary@google.com changed reviewers: + kbr@chromium.org, thestig@chromium.org
PTAL
Patchset #1 (id:1) has been deleted
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Seems fine to me. https://codereview.chromium.org/2265483002/diff/40001/content/renderer/gpu/gp... File content/renderer/gpu/gpu_benchmarking_extension.cc (right): https://codereview.chromium.org/2265483002/diff/40001/content/renderer/gpu/gp... content/renderer/gpu/gpu_benchmarking_extension.cc:552: const int width = 612; // 8.5 inch kFoo https://codereview.chromium.org/2265483002/diff/40001/content/renderer/gpu/gp... content/renderer/gpu/gpu_benchmarking_extension.cc:565: int pageCount = context.web_frame()->printBegin(params); page_count
The CQ bit was checked by halcanary@google.com to run a CQ dry run
https://codereview.chromium.org/2265483002/diff/40001/content/renderer/gpu/gp... File content/renderer/gpu/gpu_benchmarking_extension.cc (right): https://codereview.chromium.org/2265483002/diff/40001/content/renderer/gpu/gp... content/renderer/gpu/gpu_benchmarking_extension.cc:552: const int width = 612; // 8.5 inch On 2016/08/19 16:33:11, Lei Zhang wrote: > kFoo Done. https://codereview.chromium.org/2265483002/diff/40001/content/renderer/gpu/gp... content/renderer/gpu/gpu_benchmarking_extension.cc:565: int pageCount = context.web_frame()->printBegin(params); On 2016/08/19 16:33:11, Lei Zhang wrote: > page_count Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Excellent! LGTM. How about some tests though? Perhaps under src/content/test/gpu/gpu_tests/ , maybe in pixel_tests?
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/19 20:48:10, Ken Russell wrote: > Excellent! LGTM. > > How about some tests though? Perhaps under src/content/test/gpu/gpu_tests/ , > maybe in pixel_tests? chrome.gpuBenchmarking.printToSkPicture() isn't tested either, and we use it heavily on the Skia team. I'll write unit tests for both in a followup CL.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
chrome.gpuBenchmarking.printPagesToSkPictures
To use:
Launch Chrome with
--enable-gpu-benchmarking --no-sandbox
In the javascript console,
chrome.gpuBenchmarking.printPagesToSkPictures('/tmp/file.mskp')
Motivation: make debugging printing issues easier.
BUG=599185
==========
to
==========
chrome.gpuBenchmarking.printPagesToSkPictures
To use:
Launch Chrome with
--enable-gpu-benchmarking --no-sandbox
In the javascript console,
chrome.gpuBenchmarking.printPagesToSkPictures('/tmp/file.mskp')
Motivation: make debugging printing issues easier.
BUG=599185
==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from
==========
chrome.gpuBenchmarking.printPagesToSkPictures
To use:
Launch Chrome with
--enable-gpu-benchmarking --no-sandbox
In the javascript console,
chrome.gpuBenchmarking.printPagesToSkPictures('/tmp/file.mskp')
Motivation: make debugging printing issues easier.
BUG=599185
==========
to
==========
chrome.gpuBenchmarking.printPagesToSkPictures
To use:
Launch Chrome with
--enable-gpu-benchmarking --no-sandbox
In the javascript console,
chrome.gpuBenchmarking.printPagesToSkPictures('/tmp/file.mskp')
Motivation: make debugging printing issues easier.
BUG=599185
Committed: https://crrev.com/2510d9da2799341fc2acd774088a9819bcd6c71e
Cr-Commit-Position: refs/heads/master@{#413775}
==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2510d9da2799341fc2acd774088a9819bcd6c71e Cr-Commit-Position: refs/heads/master@{#413775} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
