Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/compiler/lib/src/core_types.dart

Issue 2265473004: Introduce "CommonElements" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: cl Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/core_types.dart
diff --git a/pkg/compiler/lib/src/core_types.dart b/pkg/compiler/lib/src/core_types.dart
index ff30de292dcd551f3a80c3871f32dee462b7720c..ea201f9ec784644d4018ac2b458dbc4d5e8e0a64 100644
--- a/pkg/compiler/lib/src/core_types.dart
+++ b/pkg/compiler/lib/src/core_types.dart
@@ -2,10 +2,17 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// TODO(sigmund): rename and move to common/elements.dart
library dart2js.type_system;
import 'dart_types.dart';
-import 'elements/elements.dart' show ClassElement;
+import 'elements/elements.dart'
+ show
+ ClassElement,
+ ConstructorElement,
+ FunctionElement,
+ LibraryElement,
+ Element;
/// The core classes in Dart.
abstract class CoreClasses {
@@ -61,6 +68,70 @@ abstract class CoreClasses {
ClassElement get streamClass;
}
+/// TODO(sigmund): delete CoreClasses and merge it here.
+abstract class CommonElements extends CoreClasses {
+ /// The dart:core library.
+ LibraryElement get coreLibrary;
+
+ /// The dart:async library.
+ LibraryElement get asyncLibrary;
+
+ /// The dart:mirrors library. Null if the program doesn't access dart:mirrors.
+ LibraryElement get mirrorsLibrary;
+
+ /// The dart:typed_data library.
+ LibraryElement get typedDataLibrary;
+
+ /// The `NativeTypedData` class from dart:typed_data.
+ ClassElement get typedDataClass;
+
+ // TODO(johnniwinther): Move this to the JavaScriptBackend.
+ /// The class for patch annotation defined in dart:_js_helper.
+ ClassElement get patchAnnotationClass;
+
+ // TODO(johnniwinther): Move this to the JavaScriptBackend.
+ ClassElement get nativeAnnotationClass;
+
+ /// Constructor of the `Symbol` class. This getter will ensure that `Symbol`
+ /// is resolved and lookup the constructor on demand.
+ ConstructorElement get symbolConstructor;
+
+ /// Whether [element] is the same as [symbolConstructor]. Used to check
+ /// for the constructor without computing it until it is likely to be seen.
+ bool isSymbolConstructor(Element e);
+
+ /// The `MirrorSystem` class in dart:mirrors.
+ ClassElement get mirrorSystemClass;
+
+ /// Whether [element] is `MirrorClass.getName`. Used to check for the use of
+ /// that static method without forcing the resolution of the `MirrorSystem`
+ /// class until it is necessary.
+ bool isMirrorSystemGetNameFunction(Element element);
+
+ /// The `MirrorsUsed` annotation in dart:mirrors.
+ ClassElement get mirrorsUsedClass;
+
+ /// Whether [element] is the constructor of the `MirrorsUsed` class. Used to
+ /// check for the constructor without forcing the resolution of the
+ /// `MirrorsUsed` class until it is necessary.
+ bool isMirrorsUsedConstructor(ConstructorElement element);
+
+ /// The `DeferredLibrary` annotation in dart:async that was used before the
+ /// deferred import syntax was introduced.
+ // TODO(sigmund): drop support for this old syntax?
+ ClassElement get deferredLibraryClass;
+
+ /// The function `identical` in dart:core.
+ FunctionElement get identicalFunction;
+
+ /// The method `Function.apply`.
+ FunctionElement get functionApplyMethod;
+
+ /// Whether [element] is the same as [functionApplyMethod]. This will not
+ /// resolve the apply method if it hasn't been seen yet during compilation.
+ bool isFunctionApplyMethod(Element element);
+}
+
/// The core types in Dart.
abstract class CoreTypes {
/// The `Object` type defined in 'dart:core'.
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698