Introduce "CommonElements"

pkg/compiler/lib/src/common/resolution.dart

Index: pkg/compiler/lib/src/common/resolution.dart
diff --git a/pkg/compiler/lib/src/common/resolution.dart b/pkg/compiler/lib/src/common/resolution.dart
index 42f7b32bc57ec55f8954c29b5386a2acf8350267..b58b82ef4693a5976c27ba9a2a88f561786a01c7 100644
--- a/pkg/compiler/lib/src/common/resolution.dart
+++ b/pkg/compiler/lib/src/common/resolution.dart
@@ -9,7 +9,7 @@ import '../compile_time_constants.dart';
 import '../compiler.dart' show Compiler;
 import '../constants/expressions.dart' show ConstantExpression;
 import '../constants/values.dart' show ConstantValue;
-import '../core_types.dart' show CoreClasses, CoreTypes;
+import '../core_types.dart' show CoreClasses, CoreTypes, CommonElements;
 import '../dart_types.dart' show DartType, Types;
 import '../elements/elements.dart'
     show
@@ -70,7 +70,6 @@ class ResolutionImpact extends WorldImpact {
   Iterable<dynamic> get nativeData => const <dynamic>[];
 }
 
-
 /// Interface for the accessing the front-end analysis.
 // TODO(johnniwinther): Find a better name for this.
 abstract class Frontend {
@@ -122,6 +121,7 @@ abstract class Resolution implements Frontend {
   DiagnosticReporter get reporter;
   CoreClasses get coreClasses;
   CoreTypes get coreTypes;
+  CommonElements get commonElements;
   Types get types;
   Target get target;
   ResolverTask get resolver;
@@ -131,17 +131,10 @@ abstract class Resolution implements Frontend {
   ConstantEnvironment get constants;
   MirrorUsageAnalyzerTask get mirrorUsageAnalyzerTask;
 
-  // TODO(het): Move all elements into common/elements.dart
-  LibraryElement get coreLibrary;
-  FunctionElement get identicalFunction;
-  ClassElement get mirrorSystemClass;
-  FunctionElement get mirrorSystemGetNameFunction;
-  ConstructorElement get mirrorsUsedConstructor;
-  ConstructorElement get symbolConstructor;
-
-  // TODO(het): This is only referenced in a test...
-  /// The constant for the [proxy] variable defined in dart:core.
-  ConstantValue get proxyConstant;
+  /// Whether internally we computed the constant for the [proxy] variable
+  /// defined in dart:core (used only for testing).
+  // TODO(sigmund): delete, we need a better way to test this.
+  bool get wasProxyConstantComputedTestingOnly;
 
   /// If set to `true` resolution caches will not be cleared. Use this only for
   /// testing.
@@ -163,9 +156,6 @@ abstract class Resolution implements Frontend {
   /// Resolve [element] if it has not already been resolved.
   void ensureResolved(Element element);
 
-  /// Called whenever a class has been resolved.
-  void onClassResolved(ClassElement element);
-
   /// Registers that [element] has a compile time error.
   ///
   /// The error itself is given in [message].