Introduce "CommonElements"

pkg/compiler/lib/src/core_types.dart

Index: pkg/compiler/lib/src/core_types.dart
diff --git a/pkg/compiler/lib/src/core_types.dart b/pkg/compiler/lib/src/core_types.dart
index ff30de292dcd551f3a80c3871f32dee462b7720c..ea201f9ec784644d4018ac2b458dbc4d5e8e0a64 100644
--- a/pkg/compiler/lib/src/core_types.dart
+++ b/pkg/compiler/lib/src/core_types.dart
@@ -2,10 +2,17 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// TODO(sigmund): rename and move to common/elements.dart
 library dart2js.type_system;
 
 import 'dart_types.dart';
-import 'elements/elements.dart' show ClassElement;
+import 'elements/elements.dart'
+    show
+        ClassElement,
+        ConstructorElement,
+        FunctionElement,
+        LibraryElement,
+        Element;
 
 /// The core classes in Dart.
 abstract class CoreClasses {
@@ -61,6 +68,70 @@ abstract class CoreClasses {
   ClassElement get streamClass;
 }
 
+/// TODO(sigmund): delete CoreClasses and merge it here.
+abstract class CommonElements extends CoreClasses {
+  /// The dart:core library.
+  LibraryElement get coreLibrary;
+
+  /// The dart:async library.
+  LibraryElement get asyncLibrary;
+
+  /// The dart:mirrors library. Null if the program doesn't access dart:mirrors.
+  LibraryElement get mirrorsLibrary;
+
+  /// The dart:typed_data library.
+  LibraryElement get typedDataLibrary;
+
+  /// The `NativeTypedData` class from dart:typed_data.
+  ClassElement get typedDataClass;
+
+  // TODO(johnniwinther): Move this to the JavaScriptBackend.
+  /// The class for patch annotation defined in dart:_js_helper.
+  ClassElement get patchAnnotationClass;
+
+  // TODO(johnniwinther): Move this to the JavaScriptBackend.
+  ClassElement get nativeAnnotationClass;
+
+  /// Constructor of the `Symbol` class. This getter will ensure that `Symbol`
+  /// is resolved and lookup the constructor on demand.
+  ConstructorElement get symbolConstructor;
+
+  /// Whether [element] is the same as [symbolConstructor]. Used to check
+  /// for the constructor without computing it until it is likely to be seen.
+  bool isSymbolConstructor(Element e);
+
+  /// The `MirrorSystem` class in dart:mirrors.
+  ClassElement get mirrorSystemClass;
+
+  /// Whether [element] is `MirrorClass.getName`. Used to check for the use of
+  /// that static method without forcing the resolution of the `MirrorSystem`
+  /// class until it is necessary.
+  bool isMirrorSystemGetNameFunction(Element element);
+
+  /// The `MirrorsUsed` annotation in dart:mirrors.
+  ClassElement get mirrorsUsedClass;
+
+  /// Whether [element] is the constructor of the `MirrorsUsed` class. Used to
+  /// check for the constructor without forcing the resolution of the
+  /// `MirrorsUsed` class until it is necessary.
+  bool isMirrorsUsedConstructor(ConstructorElement element);
+
+  /// The `DeferredLibrary` annotation in dart:async that was used before the
+  /// deferred import syntax was introduced.
+  // TODO(sigmund): drop support for this old syntax?
+  ClassElement get deferredLibraryClass;

[Harry Terkelsen, 2016/08/22 19:36:20]

I think we already issue a warning when we see @DeferredLibrary. I think we can
get rid of this now and just ignore @DeferredLibrary annotations (i.e. no
warning)

[Siggi Cherem (dart-lang), 2016/08/22 21:21:45]

I'm still worried that it would be a breaking change :( -- it appears that
besides the warning we still accept it and implement the deferred import with
that syntax...

+
+  /// The function `identical` in dart:core.
+  FunctionElement get identicalFunction;
+
+  /// The method `Function.apply`.
+  FunctionElement get functionApplyMethod;
+
+  /// Whether [element] is the same as [functionApplyMethod]. This will not
+  /// resolve the apply method if it hasn't been seen yet during compilation.
+  bool isFunctionApplyMethod(Element element);
+}
+
 /// The core types in Dart.
 abstract class CoreTypes {
   /// The `Object` type defined in 'dart:core'.