Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2265463002: Remove unused functions from media-controls.js (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused functions from media-controls.js This will help in getting rid of video-test.js BUG=588956 Committed: https://crrev.com/736051dd5cdf7721d35308cd523849e49e3c79d5 Cr-Commit-Position: refs/heads/master@{#413123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/media/media-controls.js View 3 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Srirama
PTAL
4 years, 4 months ago (2016-08-19 10:59:52 UTC) #3
fs
lgtm
4 years, 4 months ago (2016-08-19 11:09:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265463002/1
4 years, 4 months ago (2016-08-19 11:10:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 13:16:31 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 13:17:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/736051dd5cdf7721d35308cd523849e49e3c79d5
Cr-Commit-Position: refs/heads/master@{#413123}

Powered by Google App Engine
This is Rietveld 408576698