Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2265433002: Quick View: Stopped to show orange border when no-preview icon is clicked. (Closed)

Created:
4 years, 4 months ago by oka
Modified:
4 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: Stopped to show orange border when no-preview icon is clicked. Also make Quick View be closed when no-preview icon is clicked. BUG=632726 TEST=Manually checked Quick View is closed when no preview (or playback) icon is clicked. Also tested Quick View is not closed when image/video/audio is clicked. Committed: https://crrev.com/2561dc0f3f72edaea86101c2f87fd1352e2b6e52 Cr-Commit-Position: refs/heads/master@{#413085}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -28 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_quick_view.css View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.html View 1 3 chunks +9 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.js View 1 2 2 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
oka
nit
4 years, 4 months ago (2016-08-19 06:53:19 UTC) #1
oka
nit
4 years, 4 months ago (2016-08-19 06:57:07 UTC) #2
oka
PTAL.
4 years, 4 months ago (2016-08-19 07:08:28 UTC) #4
fukino
lgtm
4 years, 4 months ago (2016-08-19 07:27:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265433002/40001
4 years, 4 months ago (2016-08-19 07:47:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-19 08:32:44 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 08:34:24 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2561dc0f3f72edaea86101c2f87fd1352e2b6e52
Cr-Commit-Position: refs/heads/master@{#413085}

Powered by Google App Engine
This is Rietveld 408576698