Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 226543008: Ensures TopSitesImpl::MergeCachedForcedURLs doesn't keep forced URLs if they are part of the redire… (Closed)

Created:
6 years, 8 months ago by beaudoin
Modified:
6 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, browser-components-watch_chromium.org, Mathieu, manzagop (departed)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Ensures TopSitesImpl::MergeCachedForcedURLs doesn't keep forced URLs if they are part of the redirect list of an entry in non-forced URLs. BUG=360894 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/browser/history/top_sites_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites_impl_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
beaudoin
Hi Brett! Small fix. You reviewed that feature originally in: https://codereview.chromium.org/59903010/ Thanks for the review!
6 years, 8 months ago (2014-04-07 23:05:26 UTC) #1
brettw
lgtm
6 years, 8 months ago (2014-04-09 20:24:19 UTC) #2
beaudoin
The CQ bit was checked by beaudoin@chromium.org
6 years, 8 months ago (2014-04-09 21:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/226543008/1
6 years, 8 months ago (2014-04-09 21:06:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 21:41:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-09 21:41:49 UTC) #6
beaudoin
The CQ bit was checked by beaudoin@chromium.org
6 years, 8 months ago (2014-04-09 21:44:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/226543008/1
6 years, 8 months ago (2014-04-09 21:45:23 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 23:56:57 UTC) #9
Message was sent while issue was closed.
Change committed as 262866

Powered by Google App Engine
This is Rietveld 408576698