Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2265423007: [Material][Mac] Fix for bubble decoration text in dark theme (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Fix for bubble decoration text in dark theme BUG=640511 Committed: https://crrev.com/9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd Cr-Commit-Position: refs/heads/master@{#415062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
spqchan
PTAL
4 years, 3 months ago (2016-08-26 01:10:50 UTC) #2
shrike
lgtm
4 years, 3 months ago (2016-08-29 18:01:11 UTC) #3
spqchan
thanks! +avi for OWNERS
4 years, 3 months ago (2016-08-29 18:02:06 UTC) #5
Avi (use Gerrit)
lgtm stamp
4 years, 3 months ago (2016-08-29 19:00:18 UTC) #6
spqchan
On 2016/08/29 19:00:18, Avi wrote: > lgtm > > stamp thanks!
4 years, 3 months ago (2016-08-29 19:00:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265423007/1
4 years, 3 months ago (2016-08-29 19:09:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 03:52:56 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 03:55:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd
Cr-Commit-Position: refs/heads/master@{#415062}

Powered by Google App Engine
This is Rietveld 408576698