Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Side by Side Diff: chrome/browser/tracing/navigation_tracing.cc

Issue 2265423002: Revert of Background tracing: Added config option for repeated trigger behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/tracing/background_tracing_config_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tracing/navigation_tracing.h" 5 #include "chrome/browser/tracing/navigation_tracing.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 base::DictionaryValue dict; 61 base::DictionaryValue dict;
62 dict.SetString("mode", "REACTIVE_TRACING_MODE"); 62 dict.SetString("mode", "REACTIVE_TRACING_MODE");
63 63
64 std::unique_ptr<base::ListValue> rules_list(new base::ListValue()); 64 std::unique_ptr<base::ListValue> rules_list(new base::ListValue());
65 { 65 {
66 std::unique_ptr<base::DictionaryValue> rules_dict( 66 std::unique_ptr<base::DictionaryValue> rules_dict(
67 new base::DictionaryValue()); 67 new base::DictionaryValue());
68 rules_dict->SetString("rule", "TRACE_ON_NAVIGATION_UNTIL_TRIGGER_OR_FULL"); 68 rules_dict->SetString("rule", "TRACE_ON_NAVIGATION_UNTIL_TRIGGER_OR_FULL");
69 rules_dict->SetString("trigger_name", kNavigationTracingConfig); 69 rules_dict->SetString("trigger_name", kNavigationTracingConfig);
70 rules_dict->SetBoolean("stop_tracing_on_repeated_reactive", true);
71 rules_dict->SetString("category", "BENCHMARK_DEEP"); 70 rules_dict->SetString("category", "BENCHMARK_DEEP");
72 rules_list->Append(std::move(rules_dict)); 71 rules_list->Append(std::move(rules_dict));
73 } 72 }
74 { 73 {
75 std::unique_ptr<base::DictionaryValue> rules_dict( 74 std::unique_ptr<base::DictionaryValue> rules_dict(
76 new base::DictionaryValue()); 75 new base::DictionaryValue());
77 rules_dict->SetString("rule", 76 rules_dict->SetString("rule",
78 "MONITOR_AND_DUMP_WHEN_SPECIFIC_HISTOGRAM_AND_VALUE"); 77 "MONITOR_AND_DUMP_WHEN_SPECIFIC_HISTOGRAM_AND_VALUE");
79 rules_dict->SetString("category", "BENCHMARK_MEMORY_HEAVY"); 78 rules_dict->SetString("category", "BENCHMARK_MEMORY_HEAVY");
80 rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification"); 79 rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 content::BackgroundTracingManager::GetInstance()->TriggerNamedEvent( 119 content::BackgroundTracingManager::GetInstance()->TriggerNamedEvent(
121 navigation_handle, 120 navigation_handle,
122 content::BackgroundTracingManager::StartedFinalizingCallback()); 121 content::BackgroundTracingManager::StartedFinalizingCallback());
123 } 122 }
124 } 123 }
125 124
126 content::BackgroundTracingManager::TriggerHandle 125 content::BackgroundTracingManager::TriggerHandle
127 NavigationTracingObserver::navigation_handle = -1; 126 NavigationTracingObserver::navigation_handle = -1;
128 127
129 } // namespace tracing 128 } // namespace tracing
OLDNEW
« no previous file with comments | « no previous file | content/browser/tracing/background_tracing_config_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698