Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2265423002: Revert of Background tracing: Added config option for repeated trigger behavior (Closed)

Created:
4 years, 4 months ago by megjablon
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, jam, darin-cc_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 of https://codereview.chromium.org/2247033005/ ) Reason for revert: Test is flaky on builder "Android Tests" Builder: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests Failure: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/30899 Output: BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored (run #1): [ RUN ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig. [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools. ../../content/browser/tracing/background_tracing_manager_browsertest.cc:1210: Failure Value of: BackgroundTracingManagerImpl::GetInstance()->IsTracingForTesting() Actual: false Expected: true ../../content/browser/tracing/background_tracing_manager_browsertest.cc:95: Failure Value of: value Actual: true Expected: expected Which is: false [ FAILED ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored, where TypeParam = and GetParam() = (188 ms) [----------] 1 test from BackgroundTracingManagerBrowserTest (188 ms total) Original issue's description: > Background tracing: Add config option to control whether or not to stop reactive tracing when a repeated trigger occurs > > R=simonhatch@chromium.org > BUG=637129 > > Committed: https://crrev.com/fba230c24383ae08ea6d924401bdff81b46c7108 > Cr-Commit-Position: refs/heads/master@{#412577} TBR=simonhatch@chromium.org,ssid@chromium.org,petrcermak@chromium.org,oysteine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=637129 Committed: https://crrev.com/ccb0f2af13bf3cc4ebdcdd7a08e19b281d788897 Cr-Commit-Position: refs/heads/master@{#413627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -103 lines) Patch
M chrome/browser/tracing/navigation_tracing.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tracing/background_tracing_config_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_browsertest.cc View 4 chunks +0 lines, -72 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M content/browser/tracing/background_tracing_rule.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/tracing/background_tracing_rule.cc View 4 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
megjablon
Created Revert of Background tracing: Added config option for repeated trigger behavior
4 years, 4 months ago (2016-08-23 00:09:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265423002/1
4 years, 4 months ago (2016-08-23 00:10:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 01:57:47 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ccb0f2af13bf3cc4ebdcdd7a08e19b281d788897 Cr-Commit-Position: refs/heads/master@{#413627}
4 years, 4 months ago (2016-08-23 01:59:35 UTC) #7
oystein (OOO til 10th of July)
4 years, 3 months ago (2016-08-26 19:39:24 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2285853002/ by oysteine@chromium.org.

The reason for reverting is: Re-landing with fix.

Powered by Google App Engine
This is Rietveld 408576698