Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2265413002: try to build Kernel IR for SSA builder (Closed)

Created:
4 years, 4 months ago by Harry Terkelsen
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 4 months ago (2016-08-23 00:07:51 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-23 00:31:53 UTC) #3
Harry Terkelsen
4 years, 4 months ago (2016-08-23 01:40:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7923d0cba92bbf59144617c9c6a2f867de9a511a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698