content/renderer/mus/render_widget_mus_connection.cc - Issue 2265393002: Refactor compositor event handling path to be callback-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/mus/render_widget_mus_connection.cc

Issue 2265393002: Refactor compositor event handling path to be callback-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dtapuska's review 2, use WeakPtr, tweak comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/mus/compositor_mus_connection.cc ('K') | « content/renderer/mus/render_widget_mus_connection.h ('k') | ui/events/blink/input_handler_proxy.h » ('j') | ui/events/blink/input_handler_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/mus/render_widget_mus_connection.cc

diff --git a/content/renderer/mus/render_widget_mus_connection.cc b/content/renderer/mus/render_widget_mus_connection.cc

index 944121ccbd3a0847b5a35eb7f08253b99e6cdeef..9392f310c1d1b9d0255c3604c8c17ecee3b7a927 100644

--- a/content/renderer/mus/render_widget_mus_connection.cc

+++ b/content/renderer/mus/render_widget_mus_connection.cc

@@ -153,7 +153,7 @@ void RenderWidgetMusConnection::OnConnectionLost() {

}

void RenderWidgetMusConnection::OnWindowInputEvent(

- std::unique_ptr<blink::WebInputEvent> input_event,

+ ui::ScopedWebInputEvent input_event,

const base::Callback<void(ui::mojom::EventResult)>& ack) {

DCHECK(thread_checker_.CalledOnValidThread());

// If we don't yet have a RenderWidgetInputHandler then we don't yet have