Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: content/renderer/input/input_handler_manager.cc

Issue 2265393002: Refactor compositor event handling path to be callback-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: creis's review, rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/input_handler_manager.cc
diff --git a/content/renderer/input/input_handler_manager.cc b/content/renderer/input/input_handler_manager.cc
index a65a6d46447ebea97f67afe8f4ae0b45c9aa0da6..e416c97fc909f3a3caa1dc9d0234b504fdcca5b4 100644
--- a/content/renderer/input/input_handler_manager.cc
+++ b/content/renderer/input/input_handler_manager.cc
@@ -54,7 +54,8 @@ InputHandlerManager::InputHandlerManager(
: task_runner_(task_runner),
client_(client),
synchronous_handler_proxy_client_(sync_handler_client),
- renderer_scheduler_(renderer_scheduler) {
+ renderer_scheduler_(renderer_scheduler),
+ weak_ptr_factory_(this) {
DCHECK(client_);
client_->SetInputHandlerManager(this);
}
@@ -196,10 +197,11 @@ void InputHandlerManager::ProcessRafAlignedInputOnMainThread(int routing_id) {
client_->ProcessRafAlignedInput(routing_id);
}
-InputEventAckState InputHandlerManager::HandleInputEvent(
+void InputHandlerManager::HandleInputEvent(
int routing_id,
- const WebInputEvent* input_event,
- ui::LatencyInfo* latency_info) {
+ ui::ScopedWebInputEvent input_event,
+ const ui::LatencyInfo& latency_info,
+ const InputEventAckStateCallback& callback) {
DCHECK(task_runner_->BelongsToCurrentThread());
TRACE_EVENT1("input,benchmark,rail", "InputHandlerManager::HandleInputEvent",
"type", WebInputEvent::GetName(input_event->type));
@@ -209,14 +211,28 @@ InputEventAckState InputHandlerManager::HandleInputEvent(
TRACE_EVENT1("input,rail", "InputHandlerManager::HandleInputEvent",
"result", "NoInputHandlerFound");
// Oops, we no longer have an interested input handler..
- return INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
+ callback.Run(INPUT_EVENT_ACK_STATE_NOT_CONSUMED, std::move(input_event),
+ latency_info, nullptr);
+ return;
}
TRACE_EVENT1("input,rail", "InputHandlerManager::HandleInputEvent",
"result", "EventSentToInputHandlerProxy");
InputHandlerProxy* proxy = it->second->input_handler_proxy();
- InputEventAckState input_event_ack_state = InputEventDispositionToAck(
- proxy->HandleInputEventWithLatencyInfo(*input_event, latency_info));
+ proxy->HandleInputEventWithLatencyInfo(
+ std::move(input_event), latency_info,
+ base::Bind(&InputHandlerManager::DidHandleInputEventAndOverscroll,
+ weak_ptr_factory_.GetWeakPtr(), callback));
+}
+
+void InputHandlerManager::DidHandleInputEventAndOverscroll(
+ const InputEventAckStateCallback& callback,
+ InputHandlerProxy::EventDisposition event_disposition,
+ ui::ScopedWebInputEvent input_event,
+ const ui::LatencyInfo& latency_info,
+ std::unique_ptr<ui::DidOverscrollParams> overscroll_params) {
+ InputEventAckState input_event_ack_state =
+ InputEventDispositionToAck(event_disposition);
switch (input_event_ack_state) {
case INPUT_EVENT_ACK_STATE_CONSUMED:
renderer_scheduler_->DidHandleInputEventOnCompositorThread(
@@ -231,7 +247,8 @@ InputEventAckState InputHandlerManager::HandleInputEvent(
default:
break;
}
- return input_event_ack_state;
+ callback.Run(input_event_ack_state, std::move(input_event), latency_info,
+ std::move(overscroll_params));
}
void InputHandlerManager::DidOverscroll(int routing_id,
« no previous file with comments | « content/renderer/input/input_handler_manager.h ('k') | content/renderer/input/input_handler_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698