Refactor compositor event handling path to be callback-based

content/renderer/input/input_handler_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/input/input_handler_manager.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 178 matching lines @@
     int routing_id,
     blink::WebInputEvent::Type type,
     InputEventAckState ack_result) {
   client_->NotifyInputEventHandled(routing_id, type, ack_result);
 }
 
 void InputHandlerManager::ProcessRafAlignedInputOnMainThread(int routing_id) {
   client_->ProcessRafAlignedInput(routing_id);
 }
 
-InputEventAckState InputHandlerManager::HandleInputEvent(
+void InputHandlerManager::HandleInputEvent(
     int routing_id,
-    const WebInputEvent* input_event,
-    ui::LatencyInfo* latency_info) {
+    ui::ScopedWebInputEvent input_event,
+    const ui::LatencyInfo& latency_info,
+    const InputEventAckStateCallback& callback) {
   DCHECK(task_runner_->BelongsToCurrentThread());
   TRACE_EVENT1("input,benchmark,rail", "InputHandlerManager::HandleInputEvent",
                "type", WebInputEvent::GetName(input_event->type));
 
   auto it = input_handlers_.find(routing_id);
   if (it == input_handlers_.end()) {
     TRACE_EVENT1("input,rail", "InputHandlerManager::HandleInputEvent",
                  "result", "NoInputHandlerFound");
     // Oops, we no longer have an interested input handler..
-    return INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
+    callback.Run(INPUT_EVENT_ACK_STATE_NOT_CONSUMED, std::move(input_event),
+                 latency_info, nullptr);
+    return;
   }
 
   TRACE_EVENT1("input,rail", "InputHandlerManager::HandleInputEvent",
                "result", "EventSentToInputHandlerProxy");
   InputHandlerProxy* proxy = it->second->input_handler_proxy();
-  InputEventAckState input_event_ack_state = InputEventDispositionToAck(
-      proxy->HandleInputEventWithLatencyInfo(*input_event, latency_info));
+  proxy->HandleInputEventWithLatencyInfo(
+      std::move(input_event), latency_info,
+      base::Bind(&InputHandlerManager::DidHandleInputEventAndOverscroll,
+                 base::Unretained(this), callback));

[dtapuska, 2016/08/30 18:33:50]

What is the life cycle here?

[chongz, 2016/08/30 19:47:03]

According to my knowledge |InputHandlerManager| was created and destroyed along
with |RenderThreadImpl|, and |InputHandlerManager| is managing
|InputHandlerWrapper|s.

But just for safety I've changed it to WeakPtr.

+}
+
+void InputHandlerManager::DidHandleInputEventAndOverscroll(
+    const InputEventAckStateCallback& callback,
+    EventDisposition event_disposition,
+    ui::ScopedWebInputEvent input_event,
+    const ui::LatencyInfo& latency_info,
+    std::unique_ptr<ui::DidOverscrollParams> overscroll_params) {
+  InputEventAckState input_event_ack_state =
+      InputEventDispositionToAck(event_disposition);
   switch (input_event_ack_state) {
     case INPUT_EVENT_ACK_STATE_CONSUMED:
       renderer_scheduler_->DidHandleInputEventOnCompositorThread(
           *input_event,
           RendererScheduler::InputEventState::EVENT_CONSUMED_BY_COMPOSITOR);
       break;
     case INPUT_EVENT_ACK_STATE_NOT_CONSUMED:
       renderer_scheduler_->DidHandleInputEventOnCompositorThread(
           *input_event,
           RendererScheduler::InputEventState::EVENT_FORWARDED_TO_MAIN_THREAD);
       break;
     default:
       break;
   }
-  return input_event_ack_state;
+  callback.Run(input_event_ack_state, std::move(input_event), latency_info,
+               std::move(overscroll_params));
 }
 
 void InputHandlerManager::DidOverscroll(int routing_id,
                                         const ui::DidOverscrollParams& params) {
   client_->DidOverscroll(routing_id, params);
 }
 
 void InputHandlerManager::DidStartFlinging(int routing_id) {
   client_->DidStartFlinging(routing_id);
 }
 
 void InputHandlerManager::DidStopFlinging(int routing_id) {
   client_->DidStopFlinging(routing_id);
 }
 
 void InputHandlerManager::DidAnimateForInput() {
   renderer_scheduler_->DidAnimateForInputOnCompositorThread();
 }
 
 void InputHandlerManager::NeedsMainFrame(int routing_id) {
   DCHECK(task_runner_->BelongsToCurrentThread());
   auto it = input_handlers_.find(routing_id);
   if (it == input_handlers_.end())
     return;
   it->second->NeedsMainFrame();
 }
 
 }  // namespace content