Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2265383002: Copy Rasta visitor to dart2js. (Closed)

Created:
4 years, 4 months ago by Harry Terkelsen
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Copy Rasta visitor to dart2js. This code is unused now, but will be used to create the SSA graph from Kernel IR. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b86be4ea6862fe29c8bda5211f50b13654bcdfdf

Patch Set 1 #

Total comments: 1

Patch Set 2 : missed some renames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4361 lines, -0 lines) Patch
A pkg/compiler/lib/src/kernel/accessors.dart View 1 1 chunk +136 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/kernel/error.dart View 1 chunk +139 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/kernel/fall_through_visitor.dart View 1 chunk +99 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/kernel/kernel.dart View 1 chunk +584 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +2703 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/kernel/unavailable.dart View 1 chunk +133 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/kernel/unresolved.dart View 1 chunk +565 lines, -0 lines 0 comments Download
M pkg/compiler/pubspec.yaml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 4 months ago (2016-08-22 22:24:50 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2265383002/diff/1/pkg/compiler/lib/src/kernel/accessors.dart File pkg/compiler/lib/src/kernel/accessors.dart (right): https://codereview.chromium.org/2265383002/diff/1/pkg/compiler/lib/src/kernel/accessors.dart#newcode49 pkg/compiler/lib/src/kernel/accessors.dart:49: final RastaUnresolved builder; rename to UnresolvedVisitor? (same below)?
4 years, 4 months ago (2016-08-22 22:30:15 UTC) #3
Harry Terkelsen
4 years, 4 months ago (2016-08-22 22:31:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b86be4ea6862fe29c8bda5211f50b13654bcdfdf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698