Clamp font-size to 10,000 pixels

Clamp font-size to 10,000 pixels

Clamp font size to 10,000 pixels to avoid integer overflows in shaping.

BUG=630050
R=drott@chromium.org

Committed: https://crrev.com/a73929942bdadf7e78b3c118592a6c1192590a37
Cr-Commit-Position: refs/heads/master@{#413813}

[eae, 2016-08-22 22:12:18]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 22:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:45:49]

Dry run: This issue passed the CQ dry run.

[drott, 2016-08-23 15:27:33]

Do FF or other browser do something similar?

[eae, 2016-08-23 16:47:12]

On 2016/08/23 15:27:33, drott wrote:
> Do FF or other browser do something similar?

Presumably. Regardless it's not like we correctly handle 100,000 or even
1,000,000px today.

[drott, 2016-08-23 18:04:42]

On 2016/08/23 at 16:47:12, eae wrote:
> On 2016/08/23 15:27:33, drott wrote:
> > Do FF or other browser do something similar?
> 
> Presumably. Regardless it's not like we correctly handle 100,000 or even
1,000,000px today.

LGTM. Surely we don't handle it properly. My intention or idea was perhaps to
find a common number with other browser, or considering spec'ing this value.

One data point is, without looking further into the code, FF seems to clamp at
"2000", I am not sure what the unit for that value is.
https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxFont.h#50

[eae, 2016-08-23 18:05:35]

I'll do some experimentation.

[eae, 2016-08-23 19:18:59]

FF clamps at 2000px.

[eae, 2016-08-23 19:19:03]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:19:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 19:24:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-23 19:25:57]

Description was changed from

==========
Clamp font-size to 10,000 pixels

Clamp font size to 10,000 pixels to avoid integer overflows in shaping.

BUG=630050
R=drott@chromium.org
==========

to

==========
Clamp font-size to 10,000 pixels

Clamp font size to 10,000 pixels to avoid integer overflows in shaping.

BUG=630050
R=drott@chromium.org

Committed: https://crrev.com/a73929942bdadf7e78b3c118592a6c1192590a37
Cr-Commit-Position: refs/heads/master@{#413813}
==========

[commit-bot: I haz the power, 2016-08-23 19:25:58]

Patchset 1 (id:??) landed as
https://crrev.com/a73929942bdadf7e78b3c118592a6c1192590a37
Cr-Commit-Position: refs/heads/master@{#413813}