Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2265303002: simplify build sdk (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

simplify build sdk the .dart script is left over from when we couldn't build SDK via normal compile path R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/4cf8eebec783fbc3ac8e027bf5a64b5bf2178ad3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -60 lines) Patch
D tool/build_sdk.dart View 1 chunk +0 lines, -52 lines 0 comments Download
M tool/build_sdk.sh View 1 chunk +30 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-22 19:59:24 UTC) #2
vsm
lgtm
4 years, 4 months ago (2016-08-22 20:00:32 UTC) #3
Jennifer Messerly
4 years, 4 months ago (2016-08-22 20:01:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4cf8eebec783fbc3ac8e027bf5a64b5bf2178ad3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698