Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2265253002: Replace Manage Languages with dialog and dropdown item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableDisableLanguage
Patch Set: indent Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index c16e69770ad4df9448550b0e0e94628859a68032..5168f03669f61214e91bf9cc520c1c286002332c 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -46,6 +46,9 @@ Polymer({
* @private
*/
detailLanguage_: Object,
+
+ /** @private */
+ showAddLanguagesDialog_: Boolean,
},
/**
@@ -89,12 +92,18 @@ Polymer({
},
/**
- * Opens the Manage Languages page.
+ * Stamps and opens the Add Languages dialog, registering a listener to
+ * disable the dialog's dom-if again on close.
* @private
*/
- onManageLanguagesTap_: function() {
- settings.navigateTo(settings.Route.MANAGE_LANGUAGES);
- this.forceRenderList_('settings-manage-languages-page');
+ onAddLanguagesTap_: function() {
+ this.showAddLanguagesDialog_ = true;
+ this.async(function() {
+ var dialog = this.$$('settings-add-languages-dialog');
+ dialog.addEventListener('close', function() {
+ this.showAddLanguagesDialog_ = false;
+ }.bind(this));
+ });
},
/**
@@ -146,6 +155,15 @@ Polymer({
},
/**
+ * Disables the language.
+ * @param {!{model: !{item: !LanguageState}}} e
+ * @private
+ */
+ onRemoveLanguageTap_: function(e) {
+ this.languageHelper.disableLanguage(e.model.item.language.code);
+ },
+
+ /**
* Opens the Language Detail page for the language.
* @param {!{model: !{item: !LanguageState}}} e
* @private

Powered by Google App Engine
This is Rietveld 408576698