Issue 226523005: Remove IntSize::area, and rename IntSize::area_safe() to IntSize::area()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226523005: Remove IntSize::area, and rename IntSize::area_safe() to IntSize::area() (Closed)

Created:
6 years, 8 months ago by Ian Vollick

Modified:
6 years, 8 months ago

Reviewers:
esprehn

CC:
blink-reviews, jamesr, krit, jbroman, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, danakj, Rik, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove IntSize::area, and rename IntSize::area_safe() to IntSize::area() IntSize::area_safe was not named correctly for blink, and the old area function should have been deprecated anyhow. This CL cleans this up. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171363

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	Source/platform/geometry/IntSize.h	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm Awesome, you can just remove the BUG= line btw. You don't need to do ...

6 years, 8 months ago (2014-04-11 18:13:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/226523005/1

6 years, 8 months ago (2014-04-11 18:14:44 UTC) #3

Message was sent while issue was closed.

Change committed as 171363

Expand Messages | Collapse Messages