Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 226523004: Reland "More tests for Union & Intersect" (Closed)

Created:
6 years, 8 months ago by rossberg
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Reland "More tests for Union & Intersect" Fixes size approximation in Intersect. Also lowers the number of fuzzed types in test, to address time-outs. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -329 lines) Patch
M src/types.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/types.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/test-types.cc View 37 chunks +419 lines, -318 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 8 months ago (2014-04-11 15:49:28 UTC) #1
Benedikt Meurer
LGTM
6 years, 8 months ago (2014-04-12 10:32:07 UTC) #2
rossberg
6 years, 8 months ago (2014-04-14 08:46:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698