Issue 226523003: Modify the update path in PasswordSyncableService::ProcessSyncChanges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226523003: Modify the update path in PasswordSyncableService::ProcessSyncChanges. (Closed)

Created:
6 years, 8 months ago by vasilii

Modified:
6 years, 8 months ago

Reviewers:
Nicolas Zea, Garrett Casto

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Modify the update path in PasswordSyncableService::ProcessSyncChanges. Currently local data may diverge from the cloud sync data. Given that, in case of equal timestamps client shouldn't push its data to the server in MergeDataAndStartSyncing(). ProcessSyncChanges() should be straightforward, that is, updates are simply propagated to PasswordStore. BUG=361154 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263608

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -56 lines)			Patch
	M	components/password_manager/core/browser/password_syncable_service.cc	View		2 chunks	+8 lines, -33 lines	0 comments	Download
	M	components/password_manager/core/browser/password_syncable_service_unittest.cc	View		3 chunks	+20 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/226523003/1

6 years, 8 months ago (2014-04-14 07:56:32 UTC) #5

Message was sent while issue was closed.

Change committed as 263608

Expand Messages | Collapse Messages