Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2265223002: Adding ryansturm@chromium.org to data saver OWNERS files (Closed)

Created:
4 years, 4 months ago by RyanSturm
Modified:
4 years, 3 months ago
Reviewers:
Cait (Slow), tbansal1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding ryansturm@chromium.org to data saver OWNERS files This includes UI NQE, //components/data_reduction_proxy/, and spdy_proxy. Implicitly, this includes //components/previews as well. BUG= TBR=caitkp@chromium.org Committed: https://crrev.com/3c087fe9487676bd25875ed32b0a71ed69c34ac2 Cr-Commit-Position: refs/heads/master@{#414641}

Patch Set 1 #

Total comments: 4

Patch Set 2 : more ownership #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/net/nqe/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/net/spdyproxy/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/resources/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/test/data/data_reduction_proxy/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/chrome_proxy/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
RyanSturm
bengr: PTAL
4 years, 4 months ago (2016-08-22 18:33:51 UTC) #2
tbansal1
https://codereview.chromium.org/2265223002/diff/1/chrome/browser/net/spdyproxy/OWNERS File chrome/browser/net/spdyproxy/OWNERS (right): https://codereview.chromium.org/2265223002/diff/1/chrome/browser/net/spdyproxy/OWNERS#newcode4 chrome/browser/net/spdyproxy/OWNERS:4: ryansturm@chromium.org Can you add rajendrant@ also. https://codereview.chromium.org/2265223002/diff/1/components/data_reduction_proxy/OWNERS File components/data_reduction_proxy/OWNERS ...
4 years, 4 months ago (2016-08-23 01:03:25 UTC) #8
tbansal1
Also, you may want to add yourself and rajendrant to other OWNERS files too: https://cs.chromium.org/search/?q=f:OWNERS+tbansal+kundaji+sclittle+megjablon+bengr&sq=package:chromium&type=cs ...
4 years, 4 months ago (2016-08-23 01:05:47 UTC) #9
RyanSturm
https://codereview.chromium.org/2265223002/diff/1/chrome/browser/net/spdyproxy/OWNERS File chrome/browser/net/spdyproxy/OWNERS (right): https://codereview.chromium.org/2265223002/diff/1/chrome/browser/net/spdyproxy/OWNERS#newcode4 chrome/browser/net/spdyproxy/OWNERS:4: ryansturm@chromium.org On 2016/08/23 01:03:25, tbansal1 wrote: > Can you ...
4 years, 4 months ago (2016-08-24 20:31:59 UTC) #14
tbansal1
lgtm. You can TBR the OWNERS for components/resources/OWNERS.
4 years, 4 months ago (2016-08-24 20:35:13 UTC) #15
RyanSturm
caitkp: TBR components/resources/OWNERS, adding myself for data_reduction_proxy ownership.
4 years, 3 months ago (2016-08-25 21:53:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265223002/20001
4 years, 3 months ago (2016-08-25 21:54:58 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/281591)
4 years, 3 months ago (2016-08-26 00:44:38 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265223002/20001
4 years, 3 months ago (2016-08-26 01:49:16 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 03:00:25 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 03:08:16 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c087fe9487676bd25875ed32b0a71ed69c34ac2
Cr-Commit-Position: refs/heads/master@{#414641}

Powered by Google App Engine
This is Rietveld 408576698