Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2265193002: PPC/s390: [interpreter] Fix self-healing with preserved bytecode. (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [interpreter] Fix self-healing with preserved bytecode. Port 4598d9139e5930543b55bca2154afc966b64c557 Original commit message: This fixes the self-healing mechanism for closures in the interpreter entry trampoline not that bytecode can be preserved even when baseline code is already available. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:638225 LOG=N Committed: https://crrev.com/7b8d760457e48cfc2be6658b0e99f7b0a7793c78 Cr-Commit-Position: refs/heads/master@{#38799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-22 17:55:44 UTC) #1
john.yan
lgtm
4 years, 4 months ago (2016-08-22 17:57:01 UTC) #2
Michael Starzinger
LGTM. Thanks!
4 years, 4 months ago (2016-08-22 17:58:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265193002/1
4 years, 4 months ago (2016-08-22 17:59:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 18:34:41 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:35:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b8d760457e48cfc2be6658b0e99f7b0a7793c78
Cr-Commit-Position: refs/heads/master@{#38799}

Powered by Google App Engine
This is Rietveld 408576698