Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2265163002:
Updates to showError. (Closed)
|
Created:
4 years, 4 months ago by The one and only Dr. Crash Modified:
4 years, 4 months ago CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdates to showError.
Isolated from cr/2186623002 so it can be landed by hand due to
crbug/639691.
BUG=624187
TEST=browser tests in cr/2186623002
R=pastarmovj@chromium.org, xiyuan@chromium.org
Committed: https://crrev.com/d5b5c7ebea98c974fe2d1b1e26e05df0f5eda479
Cr-Commit-Position: refs/heads/master@{#413473}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 ========== to ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
drcrash@chromium.org changed reviewers: + xiyuan@chromium.org
The CQ bit was checked by drcrash@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
drcrash@chromium.org changed reviewers: + pastarmovj@chromium.org
lgtm
lgtm Could you try remove CQ_INCLUDE_TRYBOTS line and see if that would skip js lint check?
Description was changed from ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 ==========
The CQ bit was checked by drcrash@chromium.org
Sure. Just did this and started the CQ. If that fails, I'll land it by hand.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Message was sent while issue was closed.
Description was changed from ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 ========== to ========== Updates to showError. Isolated from cr/2186623002 so it can be landed by hand due to crbug/639691. BUG=624187 TEST=browser tests in cr/2186623002 R=pastarmovj@chromium.org, xiyuan@chromium.org Committed: https://crrev.com/d5b5c7ebea98c974fe2d1b1e26e05df0f5eda479 Cr-Commit-Position: refs/heads/master@{#413473} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d5b5c7ebea98c974fe2d1b1e26e05df0f5eda479 Cr-Commit-Position: refs/heads/master@{#413473} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
