Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2265133003: Fix warning message of the user profile is not seen on second instance (Closed)

Created:
4 years, 4 months ago by Qiang(Joe) Xu
Modified:
4 years, 4 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix warning message of the user profile is not seen on second instance In my cl: https://codereview.chromium.org/2258043002/, I combined updating removing warning message for both desktopUser and non-owner User into one function. However, for desktopUser build, it is done in a callback. To isolate these two platform warning message updates, the updating removing warning message function is divided into two functions. BUG=639737 TEST=tested on both browser build and chromeOS build, the bug is fixed. Committed: https://crrev.com/7e900d297b6885a43b49fd61918eda4445315381 Cr-Commit-Position: refs/heads/master@{#413974}

Patch Set 1 #

Total comments: 1

Patch Set 2 : better comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 8 chunks +37 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Qiang(Joe) Xu
Hi Alexander, could you help review on this? Thanks!
4 years, 4 months ago (2016-08-22 18:58:49 UTC) #4
Alexander Alekseev
lgtm with nits. https://codereview.chromium.org/2265133003/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2265133003/diff/1/ui/login/account_picker/user_pod_row.js#newcode1689 ui/login/account_picker/user_pod_row.js:1689: * Update the message in the ...
4 years, 4 months ago (2016-08-24 01:02:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265133003/20001
4 years, 4 months ago (2016-08-24 03:05:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 03:53:52 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 03:55:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e900d297b6885a43b49fd61918eda4445315381
Cr-Commit-Position: refs/heads/master@{#413974}

Powered by Google App Engine
This is Rietveld 408576698