Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2265133002: Remove unused gesture event builder on windows (Closed)

Created:
4 years, 4 months ago by jonross
Modified:
4 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused gesture event builder on windows Remove a method that was TODO implement me, as we do not receive these events on window anyways. TEST=events_unittests content_unittests BUG=616673 Committed: https://crrev.com/b7a247f7359d505fba360696f90456e040e9f75e Cr-Commit-Position: refs/heads/master@{#413570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
M ui/events/blink/web_input_event.cc View 3 chunks +2 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Hey Sadrul PTAL
4 years, 4 months ago (2016-08-22 20:27:09 UTC) #2
sadrul
lgtm
4 years, 4 months ago (2016-08-22 20:46:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265133002/1
4 years, 4 months ago (2016-08-22 20:48:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 23:12:43 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:15:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7a247f7359d505fba360696f90456e040e9f75e
Cr-Commit-Position: refs/heads/master@{#413570}

Powered by Google App Engine
This is Rietveld 408576698