Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2265123002: Refactor ClipPathHelper in PaintLayerPainter.cpp for reuse (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor ClipPathHelper in PaintLayerPainter.cpp for reuse Separate out client concerns and move the helper class to a new file and rename it to ClipPathClipper. This will allow sharing this code between the PaintLayerPainter and SVGPaintContext code-paths. BUG=633028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/66574fefebe275a0d8346e741730dfbb638721c5 Cr-Commit-Position: refs/heads/master@{#413518}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -77 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/ClipPathClipper.h View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/ClipPathClipper.cpp View 1 1 chunk +58 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 3 chunks +16 lines, -77 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
fs
4 years, 4 months ago (2016-08-22 15:50:14 UTC) #5
Stephen Chennney
Fix the comment then LGTM. https://codereview.chromium.org/2265123002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right): https://codereview.chromium.org/2265123002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp#newcode258 third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:258: // "object bounding box" ...
4 years, 4 months ago (2016-08-22 16:02:58 UTC) #6
fs
https://codereview.chromium.org/2265123002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right): https://codereview.chromium.org/2265123002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp#newcode258 third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:258: // "object bounding box" the offset is already accounted ...
4 years, 4 months ago (2016-08-22 16:23:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265123002/20001
4 years, 4 months ago (2016-08-22 19:58:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 20:04:25 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 20:06:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66574fefebe275a0d8346e741730dfbb638721c5
Cr-Commit-Position: refs/heads/master@{#413518}

Powered by Google App Engine
This is Rietveld 408576698