Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2265053004: Adding WebVR temporary presentation handling on mobile (Closed)

Created:
4 years, 4 months ago by bajones
Modified:
4 years, 3 months ago
Reviewers:
haraken, Mark P, yhirano
CC:
chromium-reviews, blink-reviews, haraken, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding WebVR temporary presentation handling on mobile Temporary code path that invokes fullscreen in lieu of proper VR presentation. Also includes VRDisplayEvent and related code + casing change to VRPose "timestamp" attribute to match spec. BUG=389343 Committed: https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f Cr-Commit-Position: refs/heads/master@{#414165}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing feedback #

Total comments: 2

Patch Set 3 : Addressed new comments #

Patch Set 4 : Fixed compile error #

Patch Set 5 : Rebased to fix UseCounter conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -8 lines) Patch
M third_party/WebKit/Source/core/events/EventTypeNames.in View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 5 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 2 3 7 chunks +70 lines, -8 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayEvent.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayEvent.cpp View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayEvent.idl View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 36 (19 generated)
bajones
haraken@: Could you please review changes to core/ and modules/? mpearson@: Please take a look ...
4 years, 4 months ago (2016-08-22 19:42:15 UTC) #2
Mark P
histograms.xml lgtm
4 years, 4 months ago (2016-08-22 22:46:40 UTC) #5
haraken
+yhirano for ScriptPromise handling. https://codereview.chromium.org/2265053004/diff/1/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right): https://codereview.chromium.org/2265053004/diff/1/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp#newcode106 third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:106: m_frame->domWindow()->dispatchEvent( Just to confirm: - ...
4 years, 4 months ago (2016-08-23 00:51:29 UTC) #7
bajones
Thanks for the feedback! On 2016/08/23 00:51:29, haraken wrote: > Just to confirm: > > ...
4 years, 3 months ago (2016-08-23 21:03:10 UTC) #8
haraken
LGTM https://codereview.chromium.org/2265053004/diff/20001/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right): https://codereview.chromium.org/2265053004/diff/20001/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp#newcode105 third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:105: if (m_frame) { Add '&& m_frame->localDOMWindow()' just in ...
4 years, 3 months ago (2016-08-24 01:02:34 UTC) #9
yhirano
https://codereview.chromium.org/2265053004/diff/20001/third_party/WebKit/Source/modules/vr/VRDisplay.cpp File third_party/WebKit/Source/modules/vr/VRDisplay.cpp (right): https://codereview.chromium.org/2265053004/diff/20001/third_party/WebKit/Source/modules/vr/VRDisplay.cpp#newcode155 third_party/WebKit/Source/modules/vr/VRDisplay.cpp:155: if (m_layer.source()) { What happens otherwise? Will the promise ...
4 years, 3 months ago (2016-08-24 01:39:26 UTC) #10
bajones
On 2016/08/24 01:02:34, haraken wrote: > Add '&& m_frame->localDOMWindow()' just in case. Done. On 2016/08/24 ...
4 years, 3 months ago (2016-08-24 04:06:38 UTC) #11
yhirano
lgtm
4 years, 3 months ago (2016-08-24 04:35:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265053004/60001
4 years, 3 months ago (2016-08-24 05:23:54 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/223737)
4 years, 3 months ago (2016-08-24 06:19:14 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265053004/60001
4 years, 3 months ago (2016-08-24 07:54:12 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/279831)
4 years, 3 months ago (2016-08-24 07:59:08 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265053004/80001
4 years, 3 months ago (2016-08-24 15:49:41 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/128955)
4 years, 3 months ago (2016-08-24 18:10:34 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265053004/80001
4 years, 3 months ago (2016-08-24 18:12:44 UTC) #32
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-24 22:05:23 UTC) #34
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 22:10:21 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f
Cr-Commit-Position: refs/heads/master@{#414165}

Powered by Google App Engine
This is Rietveld 408576698