Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 226503004: ARM64: Put all simulator trace on the same stream. (Closed)

Created:
6 years, 8 months ago by jbramley
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Put all simulator trace on the same stream. The simulator can trace to a specified stream, typically stderr or stdout. However, several messages (such as ASM_LOCATIONs) were printed only to stdout. As a result, they often ended up out of order with respect to the instruction trace. This patch causes all simulator output to go to the same stream. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M src/arm64/simulator-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 8 chunks +20 lines, -16 lines 0 comments Download
M src/v8utils.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbramley
6 years, 8 months ago (2014-04-08 13:20:08 UTC) #1
ulan
lgtm
6 years, 8 months ago (2014-04-08 13:21:39 UTC) #2
jbramley
6 years, 8 months ago (2014-04-08 13:27:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698