Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 226503003: Use correct call size for PredictableCodeSizeScopes. (Closed)

Created:
6 years, 8 months ago by rmcilroy
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev, Alexandre Rames
Visibility:
Public.

Description

Use correct call size for PredictableCodeSizeScopes. If out-of-line constant pool is enabled, then calls can be 3 instructions rather than 2. Fix the hard-coded PredictableCodeSizeScopes values with values based on CallSize instead. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Last fix required before ool constant pool can run cleanly through the check tests. PTAL.
6 years, 8 months ago (2014-04-08 11:43:50 UTC) #1
ulan
lgtm
6 years, 8 months ago (2014-04-08 12:18:52 UTC) #2
rmcilroy
6 years, 8 months ago (2014-04-08 12:28:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698