Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 226503002: Move modal dialogs from WebViewClient to WebFrameClient, part 1/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: works Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 051e011c8bf2480b1112d3efd379c1d40c462f4b..9cc1ac233d91e75feb6b317b7dbdcdb227822960 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -2201,13 +2201,11 @@ TEST_F(WebContentsImplTest, NoJSMessageOnInterstitials) {
// While the interstitial is showing, let's simulate the hidden page
// attempting to show a JS message.
IPC::Message* dummy_message = new IPC::Message;
- bool did_suppress_message = false;
- contents()->RunJavaScriptMessage(contents()->GetRenderViewHost(),
+ contents()->RunJavaScriptMessage(contents()->GetMainFrame(),
base::ASCIIToUTF16("This is an informative message"),
base::ASCIIToUTF16("OK"),
- kGURL, JAVASCRIPT_MESSAGE_TYPE_ALERT, dummy_message,
- &did_suppress_message);
- EXPECT_TRUE(did_suppress_message);
+ kGURL, JAVASCRIPT_MESSAGE_TYPE_ALERT, dummy_message);
+ EXPECT_TRUE(contents()->last_dialog_suppressed_);
}
// Makes sure that if the source passed to CopyStateFromAndPrune has an

Powered by Google App Engine
This is Rietveld 408576698