content/browser/web_contents/web_contents_impl_unittest.cc - Issue 226503002: Move modal dialogs from WebViewClient to WebFrameClient, part 1/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 226503002: Move modal dialogs from WebViewClient to WebFrameClient, part 1/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clean Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index 051e011c8bf2480b1112d3efd379c1d40c462f4b..b1bfa4fdc2177f8438b5588f70647d55f83787a9 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -2202,7 +2202,7 @@ TEST_F(WebContentsImplTest, NoJSMessageOnInterstitials) {

// attempting to show a JS message.

IPC::Message* dummy_message = new IPC::Message;

bool did_suppress_message = false;

- contents()->RunJavaScriptMessage(contents()->GetRenderViewHost(),

+ contents()->RunJavaScriptMessage(contents()->GetMainFrame(),

base::ASCIIToUTF16("This is an informative message"),

base::ASCIIToUTF16("OK"),

kGURL, JAVASCRIPT_MESSAGE_TYPE_ALERT, dummy_message,